Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ksagiyam/update loopy #3856

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Ksagiyam/update loopy #3856

merged 3 commits into from
Nov 11, 2024

Conversation

ksagiyam
Copy link
Contributor

@ksagiyam ksagiyam commented Nov 9, 2024

pymbolic 2024.1 requires loopy upstream main.

Depends on firedrakeproject/loopy#29

Related: firedrakeproject/tsfc#328

Copy link

github-actions bot commented Nov 10, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8090 ran6507 passed1583 skipped0 failed

Copy link

github-actions bot commented Nov 10, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8096 ran7310 passed786 skipped0 failed

@ksagiyam ksagiyam marked this pull request as ready for review November 10, 2024 00:55
@JDBetteridge
Copy link
Member

Is this required to fix current fails on master? https://github.com/firedrakeproject/firedrake/actions/runs/11760474383

@ksagiyam
Copy link
Contributor Author

Yes.

connorjward
connorjward previously approved these changes Nov 11, 2024
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@connorjward connorjward enabled auto-merge (squash) November 11, 2024 09:48
@connorjward connorjward merged commit e607414 into master Nov 11, 2024
12 checks passed
@connorjward connorjward deleted the ksagiyam/update_loopy branch November 11, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants